Trunk nightly

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: Trunk nightly

Post by cim » Mon Dec 16, 2013 6:05 pm

Not a bug as such, but it should be relatively easy to reallocate some of the launches to less busy stations in the system (or, handwavily, if the main station is so busy that the docking queues are clogged, rock hermits should do a better trade).

Can you remember what system you were in at the time?

User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 13693
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Trunk nightly

Post by Cody » Mon Dec 16, 2013 6:12 pm

cim wrote:Can you remember what system you were in at the time?
Yeah, that was Leveti (PA/F/5) - usually a pretty quiet aegis (but plenty of action out-system).
Their dreams a tattered sail in the wind

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: Trunk nightly

Post by cim » Mon Dec 16, 2013 7:14 pm

Plenty of nearby trading routes, then. It might just have scheduled a few trader launches - and it's a Feudal, so the freighters have a lot of escorts - at the same time.

User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 13693
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Trunk nightly

Post by Cody » Mon Dec 16, 2013 7:20 pm

cim wrote:Plenty of nearby trading routes, then.
Oh yes, the Maraus hub is my base of choice.
Their dreams a tattered sail in the wind

User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 13693
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Trunk nightly

Post by Cody » Mon Dec 16, 2013 8:45 pm

Just got four of these messages - are they linked to Docking Clearance by any chance? Estiri (RI/CS/13):

Code: Select all

20:40:23.865 [station.launchShip.failed]: Cancelled launch for a GalCop Viper Interceptor with role interceptor, as the Dodecahedron Station has too many ships in its launch queue(s) or no suitable launch docks.
Their dreams a tattered sail in the wind

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: Trunk nightly

Post by cim » Mon Dec 16, 2013 10:50 pm

Cody wrote:Just got four of these messages - are they linked to Docking Clearance by any chance? Estiri (RI/CS/13):

Code: Select all

20:40:23.865 [station.launchShip.failed]: Cancelled launch for a GalCop Viper Interceptor with role interceptor, as the Dodecahedron Station has too many ships in its launch queue(s) or no suitable launch docks.
Probably. Docking gets priority over launching (and Docking Clearance is always on for NPCs), so if it's a busy station, you end up with a freighter and escorts trying to dock, which takes sufficiently long that the launch queue fills up before it's finished. Long-term the busy systems should probably get more Cooperative stations in orbit to meet the demand for traffic control.

User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 13693
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Trunk nightly

Post by Cody » Fri Dec 20, 2013 11:44 pm

Those assassins, the ones that RSN doesn't* give names to - they like following me around, hitching rides through my wormholes.
Expected behaviour, I presume - but rather intimidating. I must try running dirty again soon (I've been neglecting my smuggling).

*Why is that?
Their dreams a tattered sail in the wind

User avatar
Commander McLane
Intergalactic Spam Assassin
Intergalactic Spam Assassin
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: Trunk nightly

Post by Commander McLane » Sat Dec 21, 2013 1:11 am

Cody wrote:*Why is that?
Probably because Randomshipnames OXP doesn't recognize their role and they are not declared as pirate victims (which would qualify them for a peaceful name, regardless of their actual role).

Solution: make an addition to the conditions in line 829 of the script, just like this:

Code: Select all

    // hunters, defense ships, escorts, and some special ships
    if(ship.primaryRole === "hunter" || ship.primaryRole === "defense_ship" || ship.primaryRole === "insert the primary role of those assassins here" || ship.hasRole("vector_revenge") || ship.hasRole("togy-patrol") || (ship.owner && (ship.owner.isPirateVictim || ship.owner.primaryRole === "hunter" || ship.owner.hasRole("vector"))) || (ship.scriptInfo.randomshipnames && ship.scriptInfo.randomshipnames === "hunter"))
    {
        ship.displayName += ": " + this.$randomHunterName(ship);
        return;
    }

User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 13693
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Trunk nightly

Post by Cody » Sat Dec 21, 2013 1:55 am

Thanks, McLane - soon as I find out exactly what their primary role is (assassin?), I'll make that addition.
Their dreams a tattered sail in the wind

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: Trunk nightly

Post by cim » Sat Dec 21, 2013 10:23 am

Cody wrote:Thanks, McLane - soon as I find out exactly what their primary role is (assassin?), I'll make that addition.
"assassin-light", "assassin-medium", and "assassin-heavy".

It sounds like they're working as intended, anyway...

User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 13693
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Trunk nightly

Post by Cody » Sat Dec 21, 2013 11:43 am

cim wrote:"assassin-light", "assassin-medium", and "assassin-heavy".
Thanks, Admiral - I wanted to be certain.
cim wrote:It sounds like they're working as intended, anyway...
Yeah - all good stuff. Last time I tangled with them, I reckon it was the heavy mob.
Their dreams a tattered sail in the wind

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: Trunk nightly

Post by cim » Sat Dec 21, 2013 11:59 am

[wiki]Oolite_Ship_Roles[/wiki] has the full list of 1.79 core roles, for those who are interested.

User avatar
Commander McLane
Intergalactic Spam Assassin
Intergalactic Spam Assassin
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Re: Trunk nightly

Post by Commander McLane » Sat Dec 21, 2013 1:09 pm

Cody wrote:
cim wrote:"assassin-light", "assassin-medium", and "assassin-heavy".
Thanks, Admiral - I wanted to be certain.
Which means that you have to make two more additions. I'm sure you see the pattern. :wink:

User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 13693
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Trunk nightly

Post by Cody » Sat Dec 21, 2013 1:13 pm

Commander McLane wrote:I'm sure you see the pattern.
<chortles> Yeah, this dumb pilot sees the pattern. I'll have a tinker this evening.
Their dreams a tattered sail in the wind

User avatar
cim
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 4018
Joined: Fri Nov 11, 2011 6:19 pm

Re: Trunk nightly

Post by cim » Sat Dec 21, 2013 1:32 pm

Oh, incidentally, a shorter and more future-proof way than checking for each role individually would be the test

Code: Select all

Ship.isInRoleCategory(ship.primaryRole,"oolite-assassin")
(the capital S on the first Ship is intentional)
Similar tests can be written for other role categories

Post Reply