[Solved] acceptDockingRequestFrom method not called with the sleep inducer enabled?

For test results, bug reports, announcements of new builds etc.

Moderators: winston, another_commander, Getafix

Post Reply
User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

[Solved] acceptDockingRequestFrom method not called with the sleep inducer enabled?

Post by Day » Wed Mar 27, 2019 7:19 pm

Hello everybody,

I'm currently playing with the ability to refuse docking to pilots: http://wiki.alioth.net/index.php/Oolite ... equestFrom

This works well when using the Docking Computer ('c'), but doesn't work when using the "hypnotic sleep inducer" ('C') (which means I can't dock with 'c', and CAN dock with 'C'; I should never be able to dock).

From the logs I've put in my code, it seems that the acceptDockingRequestFrom method isn't called at all with 'C'.

Is this by design, or am I missing something?

PS: currently on 1.89, commit 5cbf9c85e8341b6048e1095aefd13eea20e9f694
Last edited by Day on Mon Apr 08, 2019 9:54 am, edited 1 time in total.

another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 5397
Joined: Wed Feb 28, 2007 7:54 am

Re: acceptDockingRequestFrom method not called with the sleep inducer enabled?

Post by another_commander » Sun Mar 31, 2019 11:01 am

Can you please post a minimal OXP that demonstrates the issue?

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: acceptDockingRequestFrom method not called with the sleep inducer enabled?

Post by Day » Mon Apr 01, 2019 6:43 pm

another_commander wrote:
Sun Mar 31, 2019 11:01 am
Can you please post a minimal OXP that demonstrates the issue?
Yes :)

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: acceptDockingRequestFrom method not called with the sleep inducer enabled?

Post by Day » Sun Apr 07, 2019 2:31 pm

Here it is: https://github.com/DaymareOn/Diplomacy/ ... .Proof.oxz

How to test:
- install the oxz,
- exit your station from a savegame,
- try to enter it with 'c', it's refused as expected,
- try to enter it with 'C', it's accepted as NOT expected.

another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 5397
Joined: Wed Feb 28, 2007 7:54 am

Re: acceptDockingRequestFrom method not called with the sleep inducer enabled?

Post by another_commander » Sun Apr 07, 2019 5:39 pm

Thanks for the test case. This looks like a bug. We should have a fix in commit 9f3c9f2. Please test and let us know if there are any problems or unforseen side effects.

User avatar
Day
---- E L I T E ----
---- E L I T E ----
Posts: 518
Joined: Tue Mar 03, 2015 11:35 am
Location: Paris

Re: acceptDockingRequestFrom method not called with the sleep inducer enabled?

Post by Day » Mon Apr 08, 2019 9:53 am

another_commander wrote:
Sun Apr 07, 2019 5:39 pm
Thanks for the test case. This looks like a bug. We should have a fix in commit 9f3c9f2. Please test and let us know if there are any problems or unforseen side effects.
Tested and working :-)

No side effects seen yet, I'll tell you if I find some.

Edit: and of course, lots of thanks :mrgreen:

Post Reply