Commies.oxp (v2.07)

Discussion and information relevant to creating special missions, new ships, skins etc.

Moderators: winston, another_commander

User avatar
Commander McLane
Intergalactic Spam Assassin
Intergalactic Spam Assassin
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Post by Commander McLane » Fri Dec 12, 2008 3:17 pm

The update run of 1.72.1 reveals some problems:

Code: Select all

  [shipData.load.error]: ***** ERROR: the shipdata.plist entry "comlimesc" has a broken role definition "*FLASHER* 0.04.42 -1.54 0.0 2" (should have 8 tokens, has 5).
  [shipData.load.error]: ***** ERROR: the shipdata.plist entry "comlimesc" has a broken role definition "*FLASHER* 3.83 -2.21 -1.54 0.0 2" (should have 8 tokens, has 6).
  [shipData.load.error]: ***** ERROR: the shipdata.plist entry "comlimesc" has a broken role definition "*FLASHER* -3.83 -2.21 -1.54 0.0 2" (should have 8 tokens, has 6).
  [shipData.load.error]: ***** ERROR: the shipdata.plist entry "dock-factory" specifies non-existent model "comfactory_dock.dat".

User avatar
Commander McLane
Intergalactic Spam Assassin
Intergalactic Spam Assassin
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Post by Commander McLane » Sat Dec 13, 2008 10:26 am

Explaining on the previous post:

The flashers on the comlim-escape-pod are broken (perhaps due to a c&p-mistake). Instead of

Code: Select all

			<string>*FLASHER* 0.04.42 -1.54 0.0 2</string>
			<string>*FLASHER* 3.83 -2.21 -1.54 0.0 2</string>
			<string>*FLASHER* -3.83 -2.21 -1.54 0.0 2</string>
it should probably be

Code: Select all

			<string>*FLASHER* 0.0 4.42 -1.54 0 2 0.0 2</string>
			<string>*FLASHER* 3.83 -2.21 -1.54 0 2 0.0 2</string>
			<string>*FLASHER* -3.83 -2.21 -1.54 0 2 0.0 2</string>
(just copied from the default Oolite escape-pod's shipdata).

However, as I opened the shipdata anyway, there are some more problems: The escape-pod's script-actions are screwed up as well:

Code: Select all

		<key>script_actions</key>
		<array>
			<string>debugOn</string>
			<dict>
				<key>do</key>
				<array>
					<string>commsMessage: [commissarharikiri]</string>
					<string>setLegalStatus: 200</string>
				</array>
			</dict>
			<string>debugOff</string>
		</array>
If they start with a <key>do</key>, there is a <key>conditions</key> missing in front of it. If there are no conditions to it, the <key>do</key> is wrong, and the whole thing should just read (without the debug-commands, which aren't needed anyway except for play-testing):

Code: Select all

		<key>script_actions</key>
		<array>
			<string>commsMessage: [commissarharikiri]</string>
			<string>setLegalStatus: 200</string>
		</array>
Just by the way: It's harakiri.

Oh, and just to be sure that this is actually what you wanted: script_actions are performed if the entity gets scooped, not when it is killed (that would be death_actions). The messages themselves indeed seem to be appropriate for the case of scooping, although they seem to suggest a suicide of the sender. So probably they should include the suicide itself as well. Something like the escape pod exploding and damaging the player's fuel scoops. As this is not scriptable in legacy, perhaps it would be a good opportunity to switch to a ship-script instead of the script_actions-array? :wink:

Another easily detectable problem is in the astromine: It has station among its roles, unqualified. Which means that in Communist systems it may get chosen as main station. I doubt this is intended. So it should read station(0) instead.

The comfactory on the other hand has a ridiculously low role probability for its station-role: station(0.00000001), which may make things unnecessarily complitated for the system populator. Better use station(0) as well.

Same goes for the slapu.

Oolite's other complaint is about the missing model for dock-factory. As this version of the dock isn't used anyway (the comfactory uses slapu-dock), it should be deleted altogether. Or alternatively an extra model should be added.

Leaving shipdata now. Another problem is the existence of a descriptions.plist in the AI-folder. Has no place there, and if it is intended for use, its content should go inside the existing descriptions.plist in the Config-folder.

Furthermore, while the pleas contained in it sound communist, the key is called 'trident-plea', which is certainly not from Commies (another c&p-problem, I think).

These should be brushed out in version 2.08. And then there is this, of course. Although I don't know for the moment how to fix it.

User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Post by Eric Walch » Sat Dec 13, 2008 2:33 pm

Commander McLane wrote:Explaining on the previous post:

The flashers on the comlim-escape-pod are broken (perhaps due to a c&p-mistake). Instead of

Code: Select all

			<string>*FLASHER* 0.04.42 -1.54 0.0 2</string>
			<string>*FLASHER* 3.83 -2.21 -1.54 0.0 2</string>
			<string>*FLASHER* -3.83 -2.21 -1.54 0.0 2</string>
Strictly spoken this is not a c&p-mistake. That implies an fault by the copier. I just noticed ups has the same error. I traced it back and the fault lies within Oolite versions until 1.65. In 1.68 it was correct. I started on ups with 1.55 and commies probably sooner. We both correctly copied a wrong entry.

User avatar
Commander McLane
Intergalactic Spam Assassin
Intergalactic Spam Assassin
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Post by Commander McLane » Mon Dec 15, 2008 6:34 am

Okay, if the original entry in 1.65 was broken, then this indeed th explanation.
Eric Walch wrote:I started on ups with 1.55
:shock:

That's quite early. (Years before you registered on the board :wink: .)

User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Post by Eric Walch » Mon Dec 15, 2008 10:34 am

Commander McLane wrote:That's quite early. (Years before you registered on the board :wink: .)
Probably 1.65 was already released when I started, but yes, I only discovered this board about half a year after I started with ups.

Screet
---- E L I T E ----
---- E L I T E ----
Posts: 1883
Joined: Wed Dec 10, 2008 3:02 am
Location: Bremen, Germany

Post by Screet » Sat Dec 20, 2008 12:40 pm

Commander McLane wrote:Something like the escape pod exploding and damaging the player's fuel scoops. As this is not scriptable in legacy, perhaps it would be a good opportunity to switch to a ship-script instead of the script_actions-array?
Are you talking about damaging the scoops? That is scriptable! Thargoid has both damaged and destroyed scoops in his Pods...however I have some "random number"-problems, which caused my scoops to be destroyed before being able to fill a 25T cargo hold all the time I had the script installed. I finally got so annoyed that I removed it (and due to the wiki problems could not update to the newer version). However, it was apparently only some "very bad luck" series I had.

He also has a working trumble pod...while the "common" trumble pods seem to be empty all the time. I accidentally scooped a new trumble without his pods, though, but I don't even recall seeing a trumble on that pod ;)

Screet

User avatar
Commander McLane
Intergalactic Spam Assassin
Intergalactic Spam Assassin
Posts: 9520
Joined: Thu Dec 14, 2006 9:08 am
Location: a Hacker Outpost in a moderately remote area
Contact:

Post by Commander McLane » Sat Dec 20, 2008 1:03 pm

Screet wrote:
Commander McLane wrote:Something like the escape pod exploding and damaging the player's fuel scoops. As this is not scriptable in legacy, perhaps it would be a good opportunity to switch to a ship-script instead of the script_actions-array?
Are you talking about damaging the scoops? That is scriptable!
Yes. Which is exactly what I wrote. :wink:

User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Post by Eric Walch » Sun Oct 18, 2009 11:55 am

commies.oxp is updated to version 2.09

- Bugs mentioned in the previous few messages are fixed.
- Solar stations are now placed better in relation to the sun so they no longer explode in systems with big suns.
- All three stations are centred so they appear now in the centre of the players target reticule.

Very recent there was a rapport that one of the commies stations crashed Oolite. This was traced back by Garrett to old graphic drivers in combination with shader mode.

User avatar
Micha
Commodore
Commodore
Posts: 815
Joined: Tue Sep 02, 2008 2:01 pm
Location: London, UK
Contact:

Post by Micha » Sun Oct 18, 2009 2:17 pm

Very nice, thanks for the updates in DrNil's absence, Eric.
The glass is twice as big as it needs to be.

Screet
---- E L I T E ----
---- E L I T E ----
Posts: 1883
Joined: Wed Dec 10, 2008 3:02 am
Location: Bremen, Germany

Post by Screet » Sun Oct 25, 2009 10:45 pm

Hmmm...commies working morale? I've just seen convicts shoot up an asteroid, then the boulders...and then the splinters!

Screet

Chrisfs
---- E L I T E ----
---- E L I T E ----
Posts: 433
Joined: Sun Sep 20, 2009 10:24 am
Location: California

Post by Chrisfs » Mon Oct 26, 2009 6:27 am

Somewhat OT.
I have found AstroGulag and SLAPOs but I have yet to find a Zero Grav Factory.
Are they in Galaxy 1? Where would they be ?

User avatar
Eric Walch
Slightly Grand Rear Admiral
Slightly Grand Rear Admiral
Posts: 5536
Joined: Sat Jun 16, 2007 3:48 pm
Location: Netherlands

Post by Eric Walch » Fri Apr 30, 2010 1:51 pm

I just found in the log:

Code: Select all

WARNING: missile_role 'ecm-proof-missile' used in ship 'Commissar Limousine' needs a valid shipdata.plist entry. Using defaults instead.
WARNING: missile_role 'ecm-proof-missile' used in ship 'Military Ray' needs a valid shipdata.plist entry. Using defaults instead.
WARNING: missile_role 'ecm-proof-missile' used in ship 'Thought Police' needs a valid shipdata.plist entry. Using defaults instead.
ecm-proof-missile is no role, it's the shipkey. It should have been "EQ_HARDENED_MISSILE". I corrected this and uploaded Commies.oxp as version 2.10

This always was wrong but nobody apparently noticed those ships used plain missiles instead of the intended hardheads. All thanks to the new entry in trunk that logs this bug. Shield-tail.oxp (also from Dr.Nill) has the same bug.

Not a serious bug of cause as they still are able to fire missiles. Just not the programmed ones.
Last edited by Eric Walch on Fri Apr 30, 2010 4:26 pm, edited 1 time in total.

Chrisfs
---- E L I T E ----
---- E L I T E ----
Posts: 433
Joined: Sun Sep 20, 2009 10:24 am
Location: California

Post by Chrisfs » Fri Apr 30, 2010 3:30 pm

Thank you for uncovering secret Corporate plot to undermine the Motherland, comrade.

User avatar
snork
---- E L I T E ----
---- E L I T E ----
Posts: 551
Joined: Sat Jan 30, 2010 4:21 am
Location: northern Germany

Post by snork » Fri Apr 30, 2010 3:38 pm

Eric Walch wrote:. Shield-tail.oxp (also from Dr.Nill) has the same bug.
Shieldtail has also the bug that it tries to use hunterAI which does not exist and falls back on dumbAI .

So if you are going to fix that oxp anyway ...
<key>shtail</key>
...
<key>ai_type</key>
<string>hunterAI.plist</string>
personally I replaced it with route1patrolAI. :|

User avatar
Okti
---- E L I T E ----
---- E L I T E ----
Posts: 698
Joined: Sun Sep 26, 2010 1:51 pm
Location: A GH shop, near witchpoint to Oresrati in Galaxy 8

Re: Commies.oxp (v2.07)

Post by Okti » Sat Dec 03, 2011 9:46 pm

Done the grand tour of the 8th lately, I had to go through 3 Nova systems. One in g4 my nova system and two at G7 because I played Assasins twice before. One of the nova systems was a communist system and I realized some stations were spawned there. Looking at Commies code, it does not check for if the system has gone nova.
My OXP's
And Latest Mission Coyote's Run

Post Reply