Lighting Model

General discussion for players of Oolite.

Moderators: another_commander, winston

User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 14450
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Lighting Model

Post by Cody »

Something about nav buoys in sunlight that doesn't look right to me, and GPU usage shoots right up to 75%.
Not noticed either problem before my break. This in 1.91 (and it looks the same in 1.90) with lights down.

Image
Who was it that set up a system, a supposedly democratic system
Where you end up always voting for the lesser of two evils?
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 5880
Joined: Wed Feb 28, 2007 7:54 am

Re: Screenshots

Post by another_commander »

Cody wrote: Sun Jan 24, 2021 1:14 pm Something about nav buoys in sunlight that doesn't look right to me, and GPU usage shoots right up to 75%.
Not noticed either problem before my break. This in 1.91 (and it looks the same in 1.90) with lights down.

Image
Buoys in the core game don't have a normal map, just like everything else. Maybe that is what looks off?
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 14450
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Screenshots

Post by Cody »

Looks the same using core buoys and OXP buoys. Something about the lighting just doesn't 'feel' right. Is it only me?





I've put this in the wrong thread for some reason.
Who was it that set up a system, a supposedly democratic system
Where you end up always voting for the lesser of two evils?
User avatar
GearsNSuch
Dangerous
Dangerous
Posts: 69
Joined: Wed Jul 03, 2019 10:27 am

Re: Screenshots

Post by GearsNSuch »

Cody wrote: Sun Jan 24, 2021 1:34 pm Looks the same using core buoys and OXP buoys. Something about the lighting just doesn't 'feel' right. Is it only me?
I've put this in the wrong thread for some reason.
Could be the lighter and more saturated colors present in both buoy styles. The buoys, new and old, both seem to clash a little with most other ships, which have darker and duller textures. I’ve noticed the same thing with some ships I’ve made.
Last edited by GearsNSuch on Sun Jan 24, 2021 1:46 pm, edited 1 time in total.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 5880
Joined: Wed Feb 28, 2007 7:54 am

Re: Screenshots

Post by another_commander »

Cody wrote: Sun Jan 24, 2021 1:14 pm [...]with lights down.
Just checked this OXP and in 1.9x it does the opposite of what it claims: it raises the ambient light to 0.25, when the current default is 0.1. Apart from that, the radiance of the light source in 1.9x has been upped five times compared to previous versions. This is mainly because of many complaints we were getting of ships not being visible at long distances. If you want to adjust light source intensity, open up the oolite-default-planet.fragment and oolite-default-shader.fragment and play with the MULTIPLIER_LIGHTSRCRADIANCE and NULTIPLIER_EXPOSURE (yes, it has a typo there in one of the two files) values.
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 14450
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Screenshots

Post by Cody »

another_commander wrote: Sun Jan 24, 2021 1:44 pmJust checked this OXP and in 1.9x it does the opposite of what it claims: it raises the ambient light to 0.25, when the current default is 0.1. Apart from that, the radiance of the light source in 1.9x has been upped five times compared to previous versions.
Ah - that would fit with my general impression that Griff's ships don't look as good as they did. Oh well, a-tinkering I shall go!
Who was it that set up a system, a supposedly democratic system
Where you end up always voting for the lesser of two evils?
User avatar
montana05
---- E L I T E ----
---- E L I T E ----
Posts: 717
Joined: Mon May 30, 2016 3:54 am
Location: lurking in The Devils Triangle (G1)

Re: Screenshots

Post by montana05 »

Cody wrote: Sun Jan 24, 2021 1:53 pm
another_commander wrote: Sun Jan 24, 2021 1:44 pmJust checked this OXP and in 1.9x it does the opposite of what it claims: it raises the ambient light to 0.25, when the current default is 0.1. Apart from that, the radiance of the light source in 1.9x has been upped five times compared to previous versions.
Ah - that would fit with my general impression that Griff's ships don't look as good as they did. Oh well, a-tinkering I shall go!
The first tinkering I did after installing 1.90, cutting down the light. Most ships textures didn't look well in the latest release.
Scars remind us where we've been. They don't have to dictate where we're going.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 5880
Joined: Wed Feb 28, 2007 7:54 am

Re: Screenshots

Post by another_commander »

Cody wrote: Sun Jan 24, 2021 1:53 pm Ah - that would fit with my general impression that Griff's ships don't look as good as they did. Oh well, a-tinkering I shall go!
Careful there, Griff's ships have their own shaders and are not affected by changes in the core game's ones. They may profit a bit from reducing the ambient level though.
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 14450
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Screenshots

Post by Cody »

another_commander wrote: Sun Jan 24, 2021 2:04 pmThey may profit a bit from reducing the ambient level though.
In my personal planetinfo.plist I have this: ambient_level = 0.025; - more tinkering, methinks!


One of the gripes I have with managed OXZs: before, I'd have Griff's shipset in a meta-OXP which was a cinch to disable in order to compare with core. Not nearly so straightforward now. I may have to revert to the original OXP versions (or shunt the OXZs into AddOns).
Who was it that set up a system, a supposedly democratic system
Where you end up always voting for the lesser of two evils?
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 14450
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Screenshots

Post by Cody »

another_commander wrote: Sun Jan 24, 2021 1:44 pmThis is mainly because of many complaints we were getting of ships not being visible at long distances.
I'd argue that the need for things to look 'right' at short distances trumps that of visibility at long distances (which is not a problem I had).
Who was it that set up a system, a supposedly democratic system
Where you end up always voting for the lesser of two evils?
User avatar
montana05
---- E L I T E ----
---- E L I T E ----
Posts: 717
Joined: Mon May 30, 2016 3:54 am
Location: lurking in The Devils Triangle (G1)

Re: Lighting Model

Post by montana05 »

Cody wrote: Sun Jan 24, 2021 2:38 pm
another_commander wrote: Sun Jan 24, 2021 1:44 pmThis is mainly because of many complaints we were getting of ships not being visible at long distances.
I'd argue that the need for things to look 'right' at short distances trumps that of visibility at long distances (which is not a problem I had).
I certainly agree to that, I got various scanners to check long distance but on short distance the ship should look well.
Scars remind us where we've been. They don't have to dictate where we're going.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 5880
Joined: Wed Feb 28, 2007 7:54 am

Re: Lighting Model

Post by another_commander »

montana05 wrote: Sun Jan 24, 2021 2:45 pm
Cody wrote: Sun Jan 24, 2021 2:38 pm I'd argue that the need for things to look 'right' at short distances trumps that of visibility at long distances (which is not a problem I had).
I certainly agree to that, I got various scanners to check long distance but on short distance the ship should look well.
Agreed, but to this I'd argue that the ships do look well at close distances, when they comply to the new lighting model. I think that most of the material I am posting here at the screenshots thread looks good enough and I'm using even higher light intensities than the defaults. It's just a matter of correctly using the light model and I'm afraid that in this regard there are many OXP ships that have not been brought up to date. Those would most likely look weird. Note that the default core ship set is not excluded from this. For ships that comply to the current model (and without trying to plug my OXP, it's just the only example I know of), refer to the normal+specular+gloss maps OXP for 1.88 and later.

We could consider updating the core shipset to be what it really should be, with proper normal, specular and gloss maps, in which case we would require artists' help and would be moving a bit further away from the low-end systems support.
another_commander
Quite Grand Sub-Admiral
Quite Grand Sub-Admiral
Posts: 5880
Joined: Wed Feb 28, 2007 7:54 am

Re: Lighting Model

Post by another_commander »

Oh, and one more thing: One of the biggest issues we've always had with any light model is the total lack of shadows (not talking about the unlit parts of things, I'm talking about shadows cast by stuff on other stuff). IF we could have this, you would see a huge improvement in pretty much everything.
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 14450
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Lighting Model

Post by Cody »

another_commander wrote: Sun Jan 24, 2021 2:57 pmWe could consider updating the core shipset to be what it really should be, with proper normal, specular and gloss maps, in which case we would require artists' help and would be moving a bit further away from the low-end systems support.
That's understood, and not likely to happen. A pity, but so it goes! Shadows? I'd love shadows!


If my GTX 770 (old but has grunt) is taking a heavy hit, how are low-end systems handling it?
Who was it that set up a system, a supposedly democratic system
Where you end up always voting for the lesser of two evils?
User avatar
Cody
Sharp Shooter Spam Assassin
Sharp Shooter Spam Assassin
Posts: 14450
Joined: Sat Jul 04, 2009 9:31 pm
Location: Corke's Drift
Contact:

Re: Lighting Model

Post by Cody »

Thanks for moving it, Admiral.
Who was it that set up a system, a supposedly democratic system
Where you end up always voting for the lesser of two evils?
Post Reply